Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guzzle http version upgrade #191

Merged
merged 13 commits into from
Oct 13, 2020
Merged

guzzle http version upgrade #191

merged 13 commits into from
Oct 13, 2020

Conversation

narayana-plivo
Copy link
Contributor

In order to take advantage of the new features of PHP, Guzzle dropped the support of PHP 5. The minimum supported PHP version is now PHP 7.2. Type hints and return types for functions and methods have been added wherever possible.

Please make sure:

You are calling a function or a method with the correct type.
If you extend a class of Guzzle; update all signatures on methods you override.
Other backwards compatibility breaking changes
Class GuzzleHttp\UriTemplate is removed.
Class GuzzleHttp\Exception\SeekException is removed.
Classes GuzzleHttp\Exception\BadResponseException, GuzzleHttp\Exception\ClientException, GuzzleHttp\Exception\ServerException can no longer be initialized with an empty Response as argument.
Class GuzzleHttp\Exception\ConnectException now extends GuzzleHttp\Exception\TransferException instead of GuzzleHttp\Exception\RequestException.
Function GuzzleHttp\Exception\ConnectException::getResponse() is removed.
Function GuzzleHttp\Exception\ConnectException::hasResponse() is removed.
Constant GuzzleHttp\ClientInterface::VERSION is removed. Added GuzzleHttp\ClientInterface::MAJOR_VERSION instead.
Function GuzzleHttp\Exception\RequestException::getResponseBodySummary is removed. Use \GuzzleHttp\Psr7\get_message_body_summary as an alternative.
Function GuzzleHttp\Cookie\CookieJar::getCookieValue is removed.
Request option exception is removed. Please use http_errors.
Request option save_to is removed. Please use sink.
Pool option pool_size is removed. Please use concurrency.
We now look for environment variables in the $_SERVER super global, due to thread safety issues with getenv. We continue to fallback to getenv in CLI environments, for maximum compatibility.
The get, head, put, post, patch, delete, getAsync, headAsync, putAsync, postAsync, patchAsync, and deleteAsync methods are now implemented as genuine methods on GuzzleHttp\Client, with strong typing. The original __call implementation remains unchanged for now, for maximum backwards compatibility, but won't be invoked under normal operation.
The log middleware will log the errors with level error instead of notice
Support for international domain names (IDN) is now disabled by default, and enabling it requires installing ext-intl, linked against a modern version of the C library (ICU 4.6 or higher).

https://github.com/guzzle/guzzle/blob/master/UPGRADING.md

@drewjoh
Copy link

drewjoh commented Oct 5, 2020

Looks like this will solve #188

@cdrum
Copy link

cdrum commented Oct 13, 2020

Any chance on getting this PR approved and merged? We're getting close to a production push and we need this :/ thanks team!

@narayana-plivo narayana-plivo force-pushed the guzzlehttp_inc branch 2 times, most recently from 1ab8522 to e2c42de Compare October 13, 2020 07:27
@elijahchancey
Copy link

Same! Our dependency on plivo-php is preventing us from upgrading Laravel.

@nixonsam nixonsam merged commit 93a29d1 into master Oct 13, 2020
@nixonsam nixonsam deleted the guzzlehttp_inc branch October 13, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants