Support custom constraint (templates) #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrueg
force-pushed
the
custom-template
branch
from
e759325 to
0919e1d
Compare
mrueg
force-pushed
the
custom-template
branch
4 times, most recently
from
1c129ee to
d1bc817
Compare
mrueg
commented
Dec 3, 2024
| @@ -181,18 +181,21 @@ func (r Rego) AnnotationParameters() map[string]apiextensionsv1.JSONSchemaProps | |||
| return r.annoParameters | |||
| } | |||
|
|
|||
| func (r Rego) GetAnnotation(name string) (any, bool) { | |||
| func (r Rego) GetAnnotation(name string) (any, error) { | |||
There was a problem hiding this comment.
Had to change the signature here due to https://go.dev/src/text/template/funcs.go?s=14790:14826
mrueg
force-pushed
the
custom-template
branch
5 times, most recently
from
b48022a to
bcb185d
Compare
|
I added a bit of doc to explain when this can be useful. :) |
mrueg
force-pushed
the
custom-template
branch
2 times, most recently
from
89507e7 to
3b1d377
Compare
mrueg
force-pushed
the
custom-template
branch
from
3b1d377 to
26e720a
Compare
|
Policy check is failing due to missing "if", should be fixed with #564 |
mrueg
force-pushed
the
custom-template
branch
2 times, most recently
from
583b823 to
525ddc1
Compare
|
@jalseth this includes now a commit that fixes the failing CI due to opa v0 compatibility. |
Closed
jalseth
requested changes
Feb 9, 2025
mrueg
force-pushed
the
custom-template
branch
from
525ddc1 to
fccb865
Compare
mrueg
force-pushed
the
custom-template
branch
from
10036ca to
7085b61
Compare
mrueg
force-pushed
the
custom-template
branch
7 times, most recently
from
60e164d to
44f595f
Compare
mrueg
force-pushed
the
custom-template
branch
from
44f595f to
59fb085
Compare
jalseth
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a custom template to generate constraints and constrainttemplates with. This can be helpful in case you want to generate a helm chart or a different non-structured deployment artifact using konstraint. I've added internal/commands/constrainttemplate_template.tpl and internal/commands/constraint_template.tpl as examples how this could look like.
In addition, this adds sprout as a dependency to support more functions in the custom document template.
TODO:
Fixes: #236