Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #5

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update package.json #5

merged 1 commit into from
Feb 4, 2025

Conversation

sky-niland
Copy link
Contributor

This commit fixes an import issue for esm modules

This commit fixes an import issue for esm modules
@WillsonHaw
Copy link
Collaborator

if you can generate a changeset using pnpm changeset that would be great. Thanks!

@sky-niland
Copy link
Contributor Author

sky-niland commented Jan 31, 2025

done 👍 , but can't push as I don't have permissions

@m-hall
Copy link
Contributor

m-hall commented Feb 4, 2025

Hi @sky-niland
I don't see the changeset file. Did you push it to your branch?

Copy link
Contributor

@m-hall m-hall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just needs the changeset file.

@sky-niland
Copy link
Contributor Author

tried to create it, looked deeper into the errors would appear you have some libraries within plex I do not have permissions to and when the 'changeset' attempt to run pre-checks if fails due to these libraries

@m-hall
Copy link
Contributor

m-hall commented Feb 4, 2025

Ahh ok, I'll merge it and create the changeset separately then

@m-hall m-hall merged commit ab876e1 into plexinc:main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants