Add only-shell option to run options #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonmeyer-wk
commented
Jan 15, 2025
run_test.go
Outdated
Comment on lines
82
to
86
| err = driver.Install() | ||
| require.NoError(t, err) | ||
|
|
||
| err = driver.Uninstall() | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
I am a little uncertain on how I should be checking if only the shell browser is installed. I thought about checking through the logs like the test above does, but that could cause problems if upstream playwright repo changes how anything is logged.
|
You can check the stdout, it should contain |
|
@canstand I have implemented what you suggested. It appears to be working and have pushed up the commits. |
canstand
approved these changes
Jan 18, 2025
|
@canstand Could I get a tag with this in it? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking to add the feature defined in the docs here: https://playwright.dev/docs/browsers#optimize-download-size-on-ci so that I can reduce the amount of space used by downloading browsers. I only need to use the shell.