feat: allow query cancellation #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a second function `ExecuteWithContext` which allows passing a `net.Context` with a query. This context can be canceled, which in turn cancels calling all of the remaining resolver functions. Furthermore, resolver functions can also handle cancellation of the context. This has the added benefit of guaranteeing all resolvers will be canceled if the main Execute function returns early for any reason. Signed-off-by: Christian Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a second function
ExecuteWithContextwhich allows passing anet.Contextwith a query. This context can be canceled, which in turn cancels calling all of the remaining resolver functions. Furthermore, resolver functions can also handle cancellation of the context.This has the added benefit of guaranteeing all resolvers will be canceled if the main Execute function returns early for any reason.
Signed-off-by: Christian Stewart [email protected]