Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Model Animation Example #32

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Add Model Animation Example #32

merged 3 commits into from
Jan 8, 2025

Conversation

marklundin
Copy link
Member

This pull request includes changes to the documentation and examples for loading and animating 3D models. The most important changes include adding a new example for loading a 3D model, removing an outdated animation example, and updating the global metadata configuration.

Documentation and Example Updates:

Global Metadata Configuration:

- Added a new entry for 'glb-animation' in `_meta.global.ts` to improve navigation.
- Refactored the animation component, renaming it from `Animation` to `LoadingGLB` for clarity.
- Updated the component to include detailed comments on loading GLB files and playing animations.
- Improved camera positioning and lighting settings for better visual representation.
- Enhanced rendering logic by adding a `ShadowCatcher` component to the asset rendering process.

These changes aim to provide clearer guidance and improved functionality for GLB animations in the documentation.
- Introduced a new 'load-a-3D-model' entry in `_meta.global.ts` for improved navigation.
- Created `load-a-3D-model.mdx` to provide a comprehensive guide on loading GLB models and playing animations.
- Added `LoadingGLB` component with detailed comments on asset loading and rendering.
- Included enhanced camera and lighting settings for better visual representation.
- Implemented a `ShadowCatcher` component to improve asset rendering quality.
@marklundin marklundin added the documentation Improvements or additions to documentation label Jan 8, 2025
@marklundin marklundin requested a review from a team January 8, 2025 14:40
@marklundin marklundin merged commit a7f483b into main Jan 8, 2025
1 check passed
@marklundin marklundin deleted the feat-example-glb-loading branch January 8, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant