Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit :has_not_done filter in segments #5111

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Permit :has_not_done filter in segments #5111

merged 4 commits into from
Feb 26, 2025

Conversation

apata
Copy link
Contributor

@apata apata commented Feb 25, 2025 •
edited
Loading

Changes

  • Permits has_not_done filter in segments
  • Adds extra tests about having non-existing goals within segments.
  • Slightly changes error message upon having non-existing goals within segments, to bring it in line with other errors about selected filters.
  • Removes JS-style triple equals comparison from backend: it isn't standard

Tests

  • Automated tests have been added

Changelog

  • This PR makes an incredibly small user-facing change, which probably doesn't warrant a mention in the changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@apata apata requested a review from macobo February 25, 2025 10:00
@apata apata merged commit da74227 into saved-segments/variant-d Feb 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apata @macobo