Perf: Speed up conversions query #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macobo
force-pushed
the
speed-up-conversions-report
branch
from
d5c3734 to
2cf010a
Compare
macobo
changed the base branch from
master
to
speed-up-conversions-report-migration
macobo
changed the title
macobo
force-pushed
the
speed-up-conversions-report
branch
from
2cf010a to
53de2e2
Compare
macobo
force-pushed
the
speed-up-conversions-report
branch
from
53de2e2 to
ed8b314
Compare
RobertJoonas
approved these changes
Feb 18, 2025
macobo
merged commit f0dc53e
into
speed-up-conversions-report-migration
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5029. The conversions query became slow after this change.
The root cause was:
This change fixes that by shuffling operations around and not matching e.g. page paths on custom event goals.
Timing information
Before: 14.4s
After: 1.1s