Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make page scroll goals work in funnels #5077

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

RobertJoonas
Copy link
Contributor

Changes

Make sure page scroll goals can be added as funnel steps.

One single engagement event can count as multiple conversions in a funnel. E.g. we can add a funnel with goals like Scroll 10, Scroll 20, Scroll 30, ... Scroll 90, and see that a single engagement event with 70% scroll depth has completed every funnel step up to Scroll 70.

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

Copy link

Preview environment👷🏼‍♀️🏗️
PR-5077

Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactoring along the way 👏

@RobertJoonas RobertJoonas added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@RobertJoonas RobertJoonas added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit c97ef31 Feb 18, 2025
9 checks passed
@RobertJoonas RobertJoonas deleted the page-scroll-goals-in-funnels branch February 18, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants