Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down Postgres and Clickhouse Docker image versions in the Makefile for a consistent development environment #1017

Closed
MaybeThisIsRu opened this issue May 11, 2021 · 3 comments

Comments

@MaybeThisIsRu
Copy link
Contributor

MaybeThisIsRu commented May 11, 2021

Bug report

Describe the bug
When I followed the contributing guidelines, and brought up the Postgres and Clickhouse containers as instructed in step one, I noticed the images are not locked to any version at all. This might result in unexpected issues locally as production might be running Postgres 12.x whereas I might have Postgres 13.x locally (for an example).

Expected behavior
Postgres and Clickhouse would be locked to at least the same major version (per SemVer) as the one on production for bringing the local and production environment closer.

Screenshots (If applicable)
On running make postgres:

image

On running make clickhouse:

image

@ukutaht
Copy link
Contributor

ukutaht commented May 14, 2021

Thanks @hirusi. I've pinned the Postgres and Clickhouse versions in our hosting repo for the same reason. We should probably use the same in development: https://github.com/plausible/hosting/blob/master/docker-compose.yml

@MaybeThisIsRu
Copy link
Contributor Author

Thanks @hirusi. I've pinned the Postgres and Clickhouse versions in our hosting repo for the same reason. We should probably use the same in development: https://github.com/plausible/hosting/blob/master/docker-compose.yml

Great! Thanks for pointing that out - I've opened a PR to have specific versions locally.

There's one more improvement we could make -- that is to use volumes for the postgres container. At the moment, I have to sign up fresh on Plausible each time I boot the database container. If you're happy to have that change, I'll open a PR later on.

@ukutaht
Copy link
Contributor

ukutaht commented May 17, 2021

Yes that sounds good as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants