-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying eliminate uiComponents folder necessity #584
Conversation
Dicas para revisão de códigoCommits
SonarCloud Quality Gate
Build Github actions COM SUCESSOReactJS
ReduxAs instruções a seguir foram retiradas do Redux Style Guide.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete all unused uiComponents and all references in other files, such as comments or documentation. Search for uiComponents
in all source files to find mentions and imports.
src/containers/CompareResultsModalContainer/CompareResultsModalContainer.jsx
Outdated
Show resolved
Hide resolved
src/containers/CompareResultsModalContainer/CompareResultsModalContainer.jsx
Outdated
Show resolved
Hide resolved
src/containers/DataViewModalContainer/DataViewModalContainer.jsx
Outdated
Show resolved
Hide resolved
src/containers/DataViewModalContainer/DataViewModalContainer.jsx
Outdated
Show resolved
Hide resolved
src/containers/DataViewModalContainer/DataViewModalContainer.jsx
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 🚀
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Eliminate the use of uiComponents Folder
What is the current behavior? (You can also link to an open issue here)
Too many components to compose a final one component
What is the new behavior (if this is a feature change)?
Removed one layer os components
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
no