-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix PLATIA-2534 #582
Bug fix PLATIA-2534 #582
Conversation
Dicas para revisão de códigoCommits
SonarCloud Quality Gate
Build Github actions COM SUCESSOReactJS
ReduxAs instruções a seguir foram retiradas do Redux Style Guide.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 - The task search IS NOT working with the API (instead of filtering the array of tasks you should make an API REQUEST to filter tasks).
2 - When changing the page size or searching, the desired behavior is to reset the page number to 1, but the last page is being selected.
3 - I noticed that the buttons of the task search dropdown are in english (but should be in portuguese):
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 🚀
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Tasks are beign paginated correctly, quantified per page
What is the current behavior? (You can also link to an open issue here)
Tasks table is loading all the tasks, even showing only 10 or 20 (setted by the page size)
What is the new behavior (if this is a feature change)?
The table is loading tasks setted by the page size
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Is there any issue related to this PR in other repository? (such as platiagro/web-ui)
no
Other information:
Changes was needed on .test files