Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - New Visualization of Results #561

Merged
merged 7 commits into from
Apr 8, 2022
Merged

Feature - New Visualization of Results #561

merged 7 commits into from
Apr 8, 2022

Conversation

rudilp28
Copy link
Contributor

  • Implementation of new layout to improve visualization and comparison of results
  • individual download checkbox implementation

LuanEdCosta
LuanEdCosta reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@LuanEdCosta LuanEdCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing great, continue moving forward 🚀

@LuanEdCosta LuanEdCosta marked this pull request as ready for review March 15, 2022 17:23
@LuanEdCosta LuanEdCosta changed the title Feature/results on visualization Feature - New Visualization of Results Mar 15, 2022
LuanEdCosta
LuanEdCosta suggested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@LuanEdCosta LuanEdCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall you did a good job. 🚀

But I noticed that the usage guide is missing for these components:

  • DatasetResult
  • OperatorResultItem
  • PlotResult

You can check the MonitoringDrawerItem component for an example of how to create the usage guide.

LuanEdCosta
LuanEdCosta suggested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@LuanEdCosta LuanEdCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix styleguidist files prop types.

LuanEdCosta
LuanEdCosta approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@LuanEdCosta LuanEdCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🚀

@LuanEdCosta LuanEdCosta merged commit 43b359e into platiagro:develop Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuanEdCosta LuanEdCosta LuanEdCosta approved these changes

Assignees

@LuanEdCosta LuanEdCosta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudilp28 @LuanEdCosta