Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Axios To 0.25.0 #549

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Bump Axios To 0.25.0 #549

merged 3 commits into from
Feb 7, 2022

Conversation

LuanEdCosta
Copy link
Contributor

The dependabot axios bump PR broke some services tests.
See the checks tab for more details: #546

I merged the dependabot PR in this branch and opened another PR.

dependabot bot and others added 2 commits February 7, 2022 08:43
Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](axios/axios@v0.21.1...v0.21.2)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@LuanEdCosta LuanEdCosta requested a review from rudilp28 February 7, 2022 11:59
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Dicas para revisão de código

Commits

  • Título (1a linha do commit): apresentar resumo do que foi alterado/adicionado/removido.
    ex: adiciona action que salva parametros no backend; exibe rótulo no componente de selecao de dataset;
  • Descrição (outras linhas): dar mais detalhes de cada alteração:
    • motivos das alterações
      ex: havia um bug que causava...; nova funcionalidade que faz isso...; código foi movido para...;
    • bibliotecas adicionadas e versões (package.json)
      ex: atualiza para antd v4.6;
    • testes unitários criados/alterados
      ex: adiciona testes para a action fetchProjectSuccess;
  • Mensagens auto-explicativas! Quem revisa o código deve entender o que foi feito (e porque foi feito) sem perguntar para quem fez o commit.
  • Não devem ter conflitos. Solicitar que sejam resolvidas as ocorrências de "This branch has conflicts that must be resolved".

SonarCloud Quality Gate

  • Coverage > 80.0%, e sempre que possível = 100%
  • 0 Bugs, 0 Code Smells, 0 Vulnerabilities

Build Github actions COM SUCESSO

ReactJS

  • Usar Node 12 ou 14.
  • Remover console.log.
  • Não deixar código-fonte comentado.
  • Pasta de módulos devem ser escritas em lower case
  • Pasta de componentes devem ser escritas em camel case
  • Nunca utilizar spread em retorno de reducer sem alteração
  • Sempre utilizar hooks ao invés de HOCs
  • Itens em uma lista devem ser renderizados com uma chave única (preferir uuid)
  • Comentar apenas códigos que não estão muito claros
  • Não utilizar comentários para blocos
  • Action types devem conter @

Redux

As instruções a seguir foram retiradas do Redux Style Guide.

@LuanEdCosta
Copy link
Contributor Author

I will bump axios to 0.25.0 because 0.21.2 has a bug with interceptors and few things changed from 0.21.2 to 0.25.0. See what 0.21.3 release says:

image

@LuanEdCosta LuanEdCosta changed the title Fix - Bump Axios 0.21.1 to 0.21.2 Fix - Bump Axios Feb 7, 2022
@LuanEdCosta LuanEdCosta changed the title Fix - Bump Axios Bump Axios To 0.25.0 Feb 7, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@rudilp28 rudilp28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr ok , bug solved.

@LuanEdCosta LuanEdCosta requested a review from rudilp28 February 7, 2022 16:26
@LuanEdCosta LuanEdCosta merged commit 6db1b7d into master Feb 7, 2022
@LuanEdCosta LuanEdCosta deleted the fix/bump-axios-0.21.1-0.21.2 branch February 22, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants