Feature/user perfil page #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dicas para revisão de códigoCommits
SonarCloud Quality Gate
Build Github actions COM SUCESSOReactJS
ReduxAs instruções a seguir foram retiradas do Redux Style Guide.
|
Fix misconfiguration of API calls when running in a docker image.
fberanizo
requested changes
Sep 14, 2021
| import { AuthExpiredInterceptor } from 'services/interceptors'; | ||
| import { AXIOS_INSTANCE_FACTORY_IDENTIFIER } from 'services/factories'; | ||
|
|
||
| describe('MonitoringsApi', () => { |
There was a problem hiding this comment.
@schafferjrdev aqui ficou um describe errado MonitoringsApi -> UserProfileApi
aliás, o arquivo poderia ser renomeado para UserProfileApi.test.js
src/services/UserPerfilApi.js
Outdated
Comment on lines
1
to
19
| import { createAxiosInstance } from 'services/factories'; | ||
|
|
||
| const UserNameApi = createAxiosInstance({ | ||
| baseURL: process.env.REACT_APP_CENTRALDASHBOARD_API || 'http://localhost:8080', | ||
| }); | ||
|
|
||
| /** | ||
| * Returns monitorings from the API | ||
| * | ||
| * @returns {Promise} Get Request | ||
| */ | ||
| const getUserName = () => { | ||
| return UserNameApi.get('/api/workgroup/env-info'); | ||
| }; | ||
|
|
||
| export default { | ||
| getUserName, | ||
| axiosInstance: UserNameApi, | ||
| }; |
There was a problem hiding this comment.
@schafferjrdev aqui pode ser renomeado de UserPerfilApi.js para UserProfileApi.js
| @@ -0,0 +1,22 @@ | |||
| import UserNameApi from 'services/MonitoringsApi'; | |||
There was a problem hiding this comment.
services/MonitoringsApi também acho que pode ser UserProfileApi.js
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created store, service and page.
Has CORS error on getUserName to be fixed on develop environment.