-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zero validation on parameter config #502
Conversation
Dicas para revisão de códigoCommits
SonarCloud Quality Gate
Build Github actions COM SUCESSOReactJS
ReduxAs instruções a seguir foram retiradas do Redux Style Guide.
|
Kudos, SonarCloud Quality Gate passed! |
@@ -103,7 +103,8 @@ export const successOperatorMap = ( | |||
parameterName | |||
) => { | |||
return operatorParameters.map((parameter) => { | |||
const validParameterValue = parameterValue || undefined; | |||
const validParameterValue = | |||
parameterValue || parameterValue == 0 ? parameterValue : undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O ==
aqui é proposital? Se for tudo bem, mas acho legal sempre tomar cuidado com ele porque ele pode dar uns resultados inesperados. Ex:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Equality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Add zero validation on parameter config * Rectify sonar bug
No description provided.