Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/data split #144

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feature/data split #144

wants to merge 4 commits into from

Conversation

gvechini
Copy link
Contributor

Adicionando o componente data-split e suas adaptações nos componentes da platIA.

Gabriela Correia Vechini added 2 commits July 21, 2022 18:02
dfvneto
dfvneto suggested changes Jul 25, 2022
View reviewed changes
@dfvneto
Copy link
Contributor

dfvneto commented Jul 25, 2022

Tem que revisar também a parte de cluster pois tem que saber se esse componente vai vim instalado de forma padrão ou não. Precisa ver se precisa ser atualizada a imagem de experimento e tarefas para absorver esse componente novo

CommanderErika
CommanderErika approved these changes Jul 26, 2022
View reviewed changes
Copy link

@CommanderErika CommanderErika left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olhei as mudanças e aparenta estar tudo ok. Só não vi os arquivos relacionados a config e ymal.

@gvechini gvechini requested a review from GabrielTalasso July 26, 2022 19:22
gregorylira
gregorylira approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@gregorylira gregorylira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pelo que eu vi esta tudo certo, só não vi muito os arquivos yml.

@gvechini gvechini requested a review from DayvisonGomes July 27, 2022 19:11
@gvechini
Copy link
Contributor Author

Os arquivos que me preocupam são os de teste do data split e rf classification.

GabrielTalasso
GabrielTalasso approved these changes Jul 27, 2022
View reviewed changes
Copy link

@GabrielTalasso GabrielTalasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por aqui parece tudo certo.

dfvneto
dfvneto reviewed Jul 28, 2022
View reviewed changes
gregorylira
gregorylira reviewed Aug 5, 2022
View reviewed changes
tasks/data-split/Experiment.ipynb
"\n",
"artifacts = {\n",
" \"columns\": columns,\n",
" \"new_column_name\" = new_column_name,\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aqui não seria : tbm ?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfvneto dfvneto dfvneto requested changes

@gregorylira gregorylira gregorylira approved these changes

@CommanderErika CommanderErika CommanderErika approved these changes

@DayvisonGomes DayvisonGomes DayvisonGomes approved these changes

@GabrielTalasso GabrielTalasso GabrielTalasso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gvechini @dfvneto @CommanderErika @gregorylira @DayvisonGomes @GabrielTalasso