Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid notifying about updates on every run #120

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

pjcdawkins
Copy link
Contributor

  • Do not notify about updates on every run: notify only after checking for a new release (every hour by default).
  • Remove hardcoded state path ($HOME/.platformsh/state.json) and set it based on config.
  • Respect YAML config for updates.check and updates.check_interval if set in the embedded or environment config (however, this does not check the user config file).

Also applies config to where the state is stored instead of a hardcoded path
Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐻

@akalipetis akalipetis merged commit 5834a86 into main Sep 26, 2023
@akalipetis akalipetis deleted the updates-less-noisy branch September 26, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants