Filter out undefined headers (#40)

* Filter out undefined headers Signed-off-by: Matteo Collina <[email protected]> * fixup Signed-off-by: Matteo Collina <[email protected]> * fixup Signed-off-by: Matteo Collina <[email protected]> --------- Signed-off-by: Matteo Collina <[email protected]>
platformatic · Dec 4, 2024 · 88dee75 · 88dee75
1 parent 86654a3
commit 88dee75
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -281,10 +281,18 @@ function wire ({ server: newServer, port, ...undiciOpts }) {
     if (msg.type === 'request') {
       const { id, opts } = msg
 
+      const headers = {}
+
+      for (const [key, value] of Object.entries(opts.headers)) {
+        if (value !== undefined && value !== null) {
+          headers[key] = value
+        }
+      }
+
       const injectOpts = {
         method: opts.method,
         url: opts.path,
-        headers: opts.headers,
+        headers,
         query: opts.query,
         body: opts.body instanceof Uint8Array ? Buffer.from(opts.body) : opts.body,
       }

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -412,3 +412,23 @@ test('aborting a request', async (t) => {
     signal: abortController.signal,
   }))
 })
+
+test('empty header', async (t) => {
+  const worker = new Worker(join(__dirname, 'fixtures', 'empty-headers.js'))
+  t.after(() => worker.terminate())
+
+  const interceptor = createThreadInterceptor({
+    domain: '.local',
+  })
+  interceptor.route('myserver', worker)
+
+  const agent = new Agent().compose(interceptor)
+
+  const { statusCode, body } = await request('http://myserver.local', {
+    dispatcher: agent,
+    headers: { foo: undefined }
+  })
+
+  strictEqual(statusCode, 200)
+  deepStrictEqual(await body.text(), 'hello world')
+})
diff --git a/test/fixtures/empty-headers.js b/test/fixtures/empty-headers.js
@@ -0,0 +1,11 @@
+'use strict'
+
+const { parentPort } = require('node:worker_threads')
+const { wire } = require('../../')
+
+const app = (req, res) => {
+  // res.setHeader('foo', undefined)
+  res.end('hello world')
+}
+
+wire({ server: app, port: parentPort })