Allow custom database name override. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teejae
approved these changes
May 8, 2020
| // preferable to set this to be the same as the keyspace name to reduce | ||
| // confusion. | ||
| // | ||
| // Default: Add a "vt_" prefix to the keyspace name. |
There was a problem hiding this comment.
can you mention that the default is when the string is empty somehow? if it was a pointer, i don't think it would be a problem, but this isn't a pointer optional
Add a field to let the user customize the name of the physical MySQL database that Vitess creates. Signed-off-by: Anthony Yeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a field to let the user customize the name of the physical MySQL database that Vitess creates.