Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade etcd version from 3.3.13 to 3.5.9 #447

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

MrFabio
Copy link
Contributor

@MrFabio MrFabio commented Jul 20, 2023

This PR aims to upgrade the etcd version.

@MrFabio MrFabio force-pushed the feature/etcd-version-upgrade branch 2 times, most recently from bb54a5c to 0fc1d9d Compare July 20, 2023 17:18
@MrFabio MrFabio force-pushed the feature/etcd-version-upgrade branch from 0fc1d9d to 195d509 Compare July 20, 2023 17:18
Copy link
Collaborator

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dctrwatson Is this version of etcd okay to use?

Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait to hear back from @dctrwatson before merging though.

Thanks, @MrFabio ❤️

@Verolop
Copy link
Contributor

Verolop commented Jul 21, 2023

the versions of etcd affected by data corruption are 3.5.0 to 3.5.2, so 3.5.9 should be ok
more info:
https://groups.google.com/a/kubernetes.io/g/dev/c/B7gJs88XtQc/m/rSgNOzV2BwAJ

@mattlord mattlord merged commit c1f2ef6 into planetscale:main Jul 21, 2023
@deepthi
Copy link
Collaborator

deepthi commented Jul 21, 2023

Was there any testing of this at all? If you are already running with a released version of operator and upgrade to this PR, does everything still work fine? Under the covers there will be an etcd in-place upgrade.

@deepthi
Copy link
Collaborator

deepthi commented Jul 21, 2023

I found that the etcd project recommends taking a manual snapshot before an upgrade. We'll need to document this in the release notes.

@MrFabio MrFabio deleted the feature/etcd-version-upgrade branch July 26, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants