Add support for container lifecycle hooks in VTGate #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used to add postStart and preStop lifecycle hooks to the VTGate container. If a longer preStop hook execution is needed, this PR also adds support for customizing terminationGracePeriodSeconds of the VTGate pods. Signed-off-by: Sergey Stankevich <[email protected]>
frouioui
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Hello @stankevich, thanks for this contribution. I am not seeing any objection to it. LGTM
I'll let @GuptaManan100 also double stamp this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to add
postStartandpreStoplifecycle hooks to the VTGate container. If a longerpreStophook execution is needed, this PR also adds support for customizingterminationGracePeriodSecondsof the VTGate pods.Example use cases: delaying the shutdown of VTGate pods to let the application complete any in-flight queries, or notifying the application to gracefully disconnect from the VTGate pod that is being shut down.
Similar to #192.