Update the release instructions after v16 code freeze #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
|
I have a couple more things to add/update. Also this won't work until #371 is merged. |
…yaml file Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
approved these changes
Feb 6, 2023
mattlord
approved these changes
Feb 7, 2023
| The recommended Kubernetes versions depend on the version of the Kubernetes | ||
| client libs that Vitess Operator uses: | ||
|
|
||
| https://github.com/planetscale/vitess-operator/blob/111ac173e1c473853e66e270486ba8a9a47ecc54/go.mod#L35 |
There was a problem hiding this comment.
Do we want this to be a permanent/static link?
There was a problem hiding this comment.
I think it is fine to keep it that way. The link redirects to an old commit but at least it will always point to the same line of code. That line:
// Pinned to kubernetes-1.16.2
Is visible in all the versions of our go.mod, with the 1.16.2 being the only thing we change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of vitessio/vitess#12233. It moves the "update vitess dependency" section of the release instruction to the "Cut Release" section. We now update the vitess dependency right before cutting the release, not during the code freeze.
This PR also updates the do_release script to update the
/deploy/operator.yamlfile before doing the release.