Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes VTOrc mandatory #368

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Makes VTOrc mandatory #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
904a026
test: update vtorc test to not specify a config for vtorc
GuptaManan100 Feb 1, 2023
1bdf4c3
feat: make vtorc compulsary by adding a default
GuptaManan100 Feb 1, 2023
375b68b
feat: remove repair replication code from the operator
GuptaManan100 Feb 1, 2023
bccfd16
test: augment test to also verify VTOrc fixes primary being read-only
GuptaManan100 Feb 1, 2023
3051ad6
docs: release notes changes
GuptaManan100 Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/release-notes/2_9_0_summary.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,9 @@

The config `enforceSemiSync` is removed from the `VitessReplicationSpec`. This configuration is no longer requied.
If the users want to configure semi-sync replication, they should set the `durabilityPolicy` config to `semi_sync` in the keyspace specification.
This change of not using `enforceSemiSync` should be done before upgrading to `2.9.0` version of the operator otherwise the configuration would not be accepted.
This change of not using `enforceSemiSync` should be done before upgrading to `2.9.0` version of the operator otherwise the configuration would not be accepted.

### VTOrc becomes mandatory

VTOrc is now a **required** component of Vitess starting from v16. So, the vitess-operator will always run
a VTOrc instance for a keyspace, even if its configuration is unspecified.
4 changes: 2 additions & 2 deletions pkg/apis/planetscale/v2/vitesskeyspace_defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ func DefaultVitessKeyspace(dst *VitessKeyspace) {
}

func DefaultVitessOrchestrator(vtorc **VitessOrchestratorSpec) {
// If no vtorc is specified, we don't launch any.
// If no vtorc is specified, we want to start one since it is now a mandatory component of Vitess.
if *vtorc == nil {
return
*vtorc = &VitessOrchestratorSpec{}
}
if len((*vtorc).Resources.Requests) == 0 {
(*vtorc).Resources.Requests = corev1.ResourceList{
Expand Down
Loading