-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Vitess dependency to 14.0.0 #280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this PR are on top of #279 and should be merged after it. |
Verolop
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
Signed-off-by: Manan Gupta <[email protected]>
…y which is no longer required Signed-off-by: Manan Gupta <[email protected]>
…ies for the same now Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
update-vitess-dependency-14
branch
from
July 7, 2022 12:39
f6b7fcb
to
ec2291f
Compare
Signed-off-by: Manan Gupta <[email protected]>
This is awesome, thank you @GuptaManan100! |
GuptaManan100
added a commit
that referenced
this pull request
Jul 28, 2022
* feat: upgrade vitess dependency to v14 Signed-off-by: Manan Gupta <[email protected]> * feat: fix build issues by removing call to SetKeyspaceDurabilityPolicy which is no longer required Signed-off-by: Manan Gupta <[email protected]> * feat: cleanup semi-sync parameters being passed. Use durability policies for the same now Signed-off-by: Manan Gupta <[email protected]> * feat: upgrade test file to reflect vitess version upgrade Signed-off-by: Manan Gupta <[email protected]> * ci: upgrade go version to 1.18.3 for ci Signed-off-by: Manan Gupta <[email protected]> * ci: upgrade go version to 1.18.3 for github actions Signed-off-by: Manan Gupta <[email protected]> * feat: increment go version in the docker file too Signed-off-by: Manan Gupta <[email protected]> * feat: also upgrade vitess-operator to 2.7 in upgrade test Signed-off-by: Manan Gupta <[email protected]> * feat: remove a deprecated flag Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added a commit
that referenced
this pull request
Jul 28, 2022
* Upgrade Vitess dependency to 14.0.0 (#280) * feat: upgrade vitess dependency to v14 Signed-off-by: Manan Gupta <[email protected]> * feat: fix build issues by removing call to SetKeyspaceDurabilityPolicy which is no longer required Signed-off-by: Manan Gupta <[email protected]> * feat: cleanup semi-sync parameters being passed. Use durability policies for the same now Signed-off-by: Manan Gupta <[email protected]> * feat: upgrade test file to reflect vitess version upgrade Signed-off-by: Manan Gupta <[email protected]> * ci: upgrade go version to 1.18.3 for ci Signed-off-by: Manan Gupta <[email protected]> * ci: upgrade go version to 1.18.3 for github actions Signed-off-by: Manan Gupta <[email protected]> * feat: increment go version in the docker file too Signed-off-by: Manan Gupta <[email protected]> * feat: also upgrade vitess-operator to 2.7 in upgrade test Signed-off-by: Manan Gupta <[email protected]> * feat: remove a deprecated flag Signed-off-by: Manan Gupta <[email protected]> * feat: revert upgrading vitess versions in test Signed-off-by: Manan Gupta <[email protected]> * feat: upgrade go dependency Signed-off-by: Manan Gupta <[email protected]> * feat:upgrade vitess dependency Signed-off-by: Manan Gupta <[email protected]> * feat: fix ci workflows to also run on release-branches Signed-off-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the operator dependency to release 14.0.0. As part of this upgrade, we also clean up all the TODOs inserted during the version upgrade to 13.0.0 #263