pkg/apis/planetscale/v2: fix VitessKeyRange rounding logic #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verolop
approved these changes
Jun 15, 2022
mdlayher
force-pushed
the
mdl-sharded-keyspaces
branch
from
0a26f3d to
ee93e4c
Compare
|
@GuptaManan100 rebase complete! |
|
@mdlayher there is another rebase required. Apologies for that. |
mdlayher
force-pushed
the
mdl-sharded-keyspaces
branch
2 times, most recently
from
c49d799 to
d866a75
Compare
Signed-off-by: Matt Layher <[email protected]>
mdlayher
force-pushed
the
mdl-sharded-keyspaces
branch
from
d866a75 to
69b1c88
Compare
|
@GuptaManan100 no problem, I believe it's all set now. |
GuptaManan100
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rounding error discovered while creating a keyspace with 6 shards.
/cc @deepthi @planetscale/eng-vitess