Add integration test framework. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Yeh <[email protected]>
Signed-off-by: Anthony Yeh <[email protected]>
Signed-off-by: Anthony Yeh <[email protected]>
enisoc
force-pushed
the
integration-test
branch
from
45cb7ef to
6e8ea7d
Compare
Signed-off-by: Anthony Yeh <[email protected]>
enisoc
force-pushed
the
integration-test
branch
from
8bdbf4e to
972c327
Compare
Signed-off-by: Anthony Yeh <[email protected]>
PrismaPhonic
approved these changes
Dec 12, 2019
| // We use the fork path primarily to decide which controllers to run in this | ||
| // manager process. Not all controllers run in the root process, for example. | ||
| switch forkPath { | ||
| case "": |
There was a problem hiding this comment.
Can we make this a dedicated type? I'm not a huge fan of comparing against an empty string. It doesn't communicate much to a reader.
There was a problem hiding this comment.
This isn't new code; I'm just moving things around to make them easier to test. If you have an idea to make this better, can you send a separate PR?
PrismaPhonic
added a commit
that referenced
this pull request
Dec 17, 2019
… it doesn't get committed accidentally Added ExtraVitessFlags field where required so we can pass down to vtctld, vtgate and vttablet Auto-generate after make generate Merge ExtraVitessFlags from root into ExtraFlags so we don't have to add an extra field to Specs Make sure we bring in ExtraVitessFlags from vt here so child components can merge it into their ExtraFlags Added ExtraVitessFlags where necessary and plumbed through. Merging ExtraVitessFlags into ExtraFlags to match newly established pattern. Added logic to bring in ExtraFlags, and merge ExtraVitessFlags from parent higher up Auto-generated. Add automated unit test job. (#6) Signed-off-by: Anthony Yeh <[email protected]> Add a Dockerfile for building release images. (#8) We can't change the default Dockerfile because operator-sdk expects it to behave a certain way. Instead, we'll build releases from this new Dockerfile.release. Signed-off-by: Anthony Yeh <[email protected]> Point deploy to Docker Hub. (#9) This is where we'll be publishing images. Signed-off-by: Anthony Yeh <[email protected]> Add integration test framework. (#10) * Move logic from cmd/manager to a package for easier testing. Signed-off-by: Anthony Yeh <[email protected]> * Add integration test framework. Signed-off-by: Anthony Yeh <[email protected]> * Add integration-test workflow. Signed-off-by: Anthony Yeh <[email protected]> * integration/framework: Wait for CRDs to be ready. Signed-off-by: Anthony Yeh <[email protected]> * Switch to controller-runtime client. Signed-off-by: Anthony Yeh <[email protected]> Add support for pod annotations (#7) * Add support for pod annotations Signed-off-by: avaidyanatha <[email protected]> * Implement annotations for deployment based pods Signed-off-by: avaidyanatha <[email protected]> * Implement annotations for vtgate Signed-off-by: avaidyanatha <[email protected]> * Add hashing for vttablet deployments and fix bugs Signed-off-by: avaidyanatha <[email protected]> * Update hash function for map[string]string Signed-off-by: avaidyanatha <[email protected]> * Update hashing function Signed-off-by: avaidyanatha <[email protected]> * Clobber input map for vtgate deployment Signed-off-by: avaidyanatha <[email protected]> * Address review comments Signed-off-by: avaidyanatha <[email protected]> * Add stringmaps package and autogen files Signed-off-by: avaidyanatha <[email protected]> * Address review comments Signed-off-by: avaidyanatha <[email protected]> Replace deprecated vttablet and vtbackup charset flags (#11) Signed-off-by: Jacques Grove <[email protected]> Rearrange README order and note about the vtctl reference guide (#12) Signed-off-by: avaidyanatha <[email protected]> re-ran make generate Signed-off-by: Peter Farr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a framework, which is mostly copied from the one I wrote for Metacontroller. I'll fill in the skeleton test in a separate PR. For now, it just tests that we can bring up the operator and its dependencies.