Django fields testing #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaykatheria
force-pushed
the
django-fields
branch
9 times, most recently
from
87a5f79 to
0854d55
Compare
This commit adds test for different django fields and some of their parameters. This commit also adds model-bakery as a requirement which is used to create mock objects of model classes and facilitates testing. work towards vitessio/vitess#7905 Signed-off-by: Abhay Katheria <[email protected]>
abhaykatheria
force-pushed
the
django-fields
branch
from
0854d55 to
11c93b2
Compare
GuptaManan100
approved these changes
Jun 2, 2021
frameworks/python/django/src/testApp/test/test_fields/test_fields.py
Outdated
Show resolved
Hide resolved
mcronce
suggested changes
Jun 2, 2021
… to be persistent and updated the url for django fields guide
abhaykatheria
force-pushed
the
django-fields
branch
from
3124e5e to
5130ce8
Compare
GuptaManan100
approved these changes
Jun 3, 2021
mcronce
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
@abhaykatheria sorry, I didn't catch the notification that you'd pushed an update yesterday :)
This is fine to merge, I'll push a follow up afterward to explain by example exactly what I'm looking for, and I'll throw some comments in to make it more clear
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds test for different django fields and
some of their parameters.
This commit also adds model-bakery as a requirement which
is used to create mock objects of model classes and facilitates
testing.
work towards vitessio/vitess#7905
Signed-off-by: abhaykatheria [email protected]