Change how we establish connection + Rails 6 support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using credentials, we are able to make the rake tasks more reliable (some envs would fail using pscale connect). We are also able to remove the need for people to have to configure `database.yml` specifically to work with this gem. By setting `DATABASE_URL`, we override what is set in `database.yml`.
no-itsbackpack
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor of the rake tasks to make use of
pscale password createinstead ofpscale connect.Replacing
pscale connectwith credsCurrently the gem runs
pscale connectto establish a local port connection to PlanetScale. This can cause problems in some environments. Plus it requires customization of the appsdatabase.yml.This PR changes the gem so that we instead create credentials, set them as
DATABASE_URLand connect directly to the PlanetScale DB. After the command is run, the credentials are removed.Rails 6 support
Opening up the dependencies to allow Rails 6. Nearly everything works the same as Rails 7 with the exception of
db:rollbackfor multiple database apps running on versions older than6.1.