Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Swarm<T>.Reorged event #945

Merged

Conversation

riemannulus
Copy link
Collaborator

No description provided.

@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from 579c8d5 to 851569b Compare August 5, 2020 08:40
@riemannulus riemannulus changed the title Introduce ReorgRender API Introduce OnReorg API Aug 5, 2020
@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from c736c78 to 6ed346c Compare August 5, 2020 08:58
@riemannulus riemannulus changed the title Introduce OnReorg API Introduce Reorged API Aug 5, 2020
@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from eefa55b to 91401d6 Compare August 5, 2020 09:12
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #945 into master will decrease coverage by 73.41%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #945       +/-   ##
===========================================
- Coverage   88.01%   14.59%   -73.42%     
===========================================
  Files         269      245       -24     
  Lines       24824    24182      -642     
===========================================
- Hits        21848     3529    -18319     
- Misses       1517    20494    +18977     
+ Partials     1459      159     -1300     
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/BlockChainTest.cs 0.00% <0.00%> (-98.37%) ⬇️
Libplanet/Blockchain/BlockChain.cs 41.03% <0.00%> (-48.93%) ⬇️
Libplanet/Net/PeerState.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet.Stun/Stun/Crc32.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Blocks/RawBlock.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/FixedSizedQueue.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/Messages/Tx.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/SwarmOptions.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/AddressExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/Messages/Ping.cs 0.00% <0.00%> (-100.00%) ⬇️
... and 234 more

@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from 91401d6 to 24e82bb Compare August 5, 2020 09:47
@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from 24e82bb to a6e54ad Compare August 5, 2020 09:52
@riemannulus riemannulus marked this pull request as ready for review August 5, 2020 09:52
@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from a6e54ad to 56c9ce1 Compare August 5, 2020 09:57
moreal
moreal previously approved these changes Aug 5, 2020
@riemannulus riemannulus requested review from earlbread and moreal August 6, 2020 03:21
@dahlia dahlia changed the title Introduce Reorged API Introduce Swarm<T>.Reorged event Aug 6, 2020
moreal
moreal previously approved these changes Aug 6, 2020
@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from cd1d870 to 1e3a5b6 Compare August 6, 2020 06:00
@riemannulus riemannulus requested a review from dahlia August 6, 2020 06:02
@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from 1e3a5b6 to d4a1e47 Compare August 6, 2020 07:18
Copy link
Contributor

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assure it'll be my last turn.

@riemannulus riemannulus force-pushed the feature/reorg-render-api branch from d4a1e47 to 617b615 Compare August 6, 2020 07:55
Copy link
Contributor

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@riemannulus riemannulus merged commit f29f7be into planetarium:master Aug 6, 2020
dahlia added a commit to dahlia/libplanet that referenced this pull request Aug 23, 2020
which is replaced by IRenderer<T>.RenderReorg() method.

See also planetarium#945
dahlia added a commit to dahlia/libplanet that referenced this pull request Aug 24, 2020
which is replaced by IRenderer<T>.RenderReorg() method.

See also planetarium#945
dahlia added a commit to dahlia/libplanet that referenced this pull request Aug 24, 2020
which is replaced by IRenderer<T>.RenderReorg() method.

See also planetarium#945
dahlia added a commit to dahlia/libplanet that referenced this pull request Aug 24, 2020
which is replaced by IRenderer<T>.RenderReorg() method.

See also planetarium#945
@riemannulus riemannulus self-assigned this Sep 2, 2020
@riemannulus riemannulus deleted the feature/reorg-render-api branch January 27, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants