Throw exception with network based on different genesis #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 86.48% 86.54% +0.05%
==========================================
Files 222 222
Lines 19232 19261 +29
==========================================
+ Hits 16633 16669 +36
+ Misses 1419 1411 -8
- Partials 1180 1181 +1
|
moreal
force-pushed
the
make-swarm-notify-different-network-during-fill-block
branch
from
5037302 to
ef0939a
Compare
moreal
changed the title
moreal
changed the title
moreal
force-pushed
the
make-swarm-notify-different-network-during-fill-block
branch
from
ef0939a to
7b8a50b
Compare
longfin
requested changes
Jan 3, 2020
earlbread
reviewed
Jan 3, 2020
moreal
force-pushed
the
make-swarm-notify-different-network-during-fill-block
branch
from
bdebe97 to
cc6edb6
Compare
longfin
approved these changes
Jan 3, 2020
earlbread
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no action when
Swarm<T>received blocks of other network (chain). It caused that the node entered to wrong network but it couldn't realize. So I made it to throw exception in the case. In addition, IMO it's better to remove the peer from the peers table but I'm not sure it's okay.Please leave commnets if you have some opinions about that. 😁