Calculate state if received state height is shorter than Tip #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
previously approved these changes
Dec 18, 2019
longfin
requested changes
Dec 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 86.71% 86.73% +0.02%
==========================================
Files 222 222
Lines 18824 18884 +60
==========================================
+ Hits 16323 16379 +56
- Misses 1345 1349 +4
Partials 1156 1156
|
dahlia
reviewed
Dec 18, 2019
earlbread
force-pushed
the
fix-receive-recent-state
branch
from
da506c2 to
32d410d
Compare
limebell
previously approved these changes
Dec 18, 2019
longfin
previously approved these changes
Dec 18, 2019
dahlia
previously approved these changes
Dec 18, 2019
earlbread
force-pushed
the
fix-receive-recent-state
branch
from
32d410d to
c9954e3
Compare
limebell
approved these changes
Dec 18, 2019
dahlia
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the states were empty between the tip of the peer to receive the states and the tip of the downloaded block.