Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state ref even if block state exists #704

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

earlbread
Copy link
Contributor

Fixed a bug where the state reference would not be updated when forking a chain and adding existed blocks.

@earlbread earlbread added the bug Something isn't working label Dec 4, 2019
@earlbread earlbread self-assigned this Dec 4, 2019
longfin
longfin previously approved these changes Dec 4, 2019
@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #704 into master will increase coverage by 0.02%.
The diff coverage is 91.3%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   85.86%   85.89%   +0.02%     
==========================================
  Files         222      222              
  Lines       18332    18356      +24     
==========================================
+ Hits        15741    15767      +26     
+ Misses       1463     1461       -2     
  Partials     1128     1128
Impacted Files Coverage Δ
Libplanet/Store/DefaultStore.cs 85.81% <100%> (+0.12%) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.65% <100%> (+0.01%) ⬆️
Libplanet/Blockchain/BlockChain.cs 90.88% <80.95%> (ø) ⬆️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 79.63% <0%> (+0.9%) ⬆️

moreal
moreal previously approved these changes Dec 4, 2019
dahlia
dahlia previously approved these changes Dec 4, 2019
@earlbread earlbread dismissed stale reviews from dahlia, moreal, and longfin via 6e9fca1 December 5, 2019 03:02
@earlbread earlbread force-pushed the fix-setstate-after-fork branch from 705dacf to 6e9fca1 Compare December 5, 2019 03:02
@earlbread
Copy link
Contributor Author

I fixed ForkStateReferences not to copy state references of the genesis block.

@earlbread earlbread merged commit 9cf9f3d into planetarium:master Dec 5, 2019
@earlbread earlbread deleted the fix-setstate-after-fork branch December 5, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants