Protected private key & Web3 Secret Storage Definition #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
force-pushed
the
protected-private-key
branch
from
9d5d39e to
7ae1f30
Compare
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
- Coverage 90.82% 88.17% -2.66%
==========================================
Files 202 217 +15
Lines 15815 17152 +1337
==========================================
+ Hits 14364 15123 +759
- Misses 1146 1153 +7
- Partials 305 876 +571
|
dahlia
force-pushed
the
protected-private-key
branch
2 times, most recently
from
d944d7f to
eed97be
Compare
dahlia
changed the title
earlbread
reviewed
Oct 31, 2019
longfin
reviewed
Oct 31, 2019
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Oct 31, 2019
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Oct 31, 2019
It allocates only once if the source's length is known (i.e., the source implements ICollection<T>). planetarium#614 (comment)
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Oct 31, 2019
dahlia
force-pushed
the
protected-private-key
branch
from
eed97be to
67c5050
Compare
longfin
previously approved these changes
Oct 31, 2019
earlbread
approved these changes
Oct 31, 2019
earlbread
previously approved these changes
Oct 31, 2019
It allocates only once if the source's length is known (i.e., the source implements ICollection<T>). planetarium#614 (comment)
dahlia
force-pushed
the
protected-private-key
branch
from
67c5050 to
512f3c7
Compare
longfin
approved these changes
Oct 31, 2019
earlbread
approved these changes
Oct 31, 2019
This was referenced Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements #577.
ProtectedPrivateKeyprotects aPrivateKeywith a user input passphrase (i.e., password), and can be stored as a JSON data according to Ethereum's Web3 Secret Storage Definition (so-called “keystore”).At the moment, it implements only minimum compliance according to the spec,
pbkdf2andaes-128-ctr: