-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename variable according to #555 #558
Conversation
@dahlia I'm having troubles understanding what is expected to pass the changelog check, could you help me ? |
@pBouillon You need to write a log about this change into - Renamed `minValue`/`maxValue` parameters to `lowerBound`/`upperBound`
of `IRandom.Next()` methods. [[#555], [#558]] Also there should be reference definitions for |
Thank you ! It's done with the relevant links to the issue and this PR |
@dahlia All tests clear ! I also rebased my fork from the remote master branch, do I need to add anything else to this PR ? 😄 |
@pBouillon Sorry, but could you rebase your changes on the current master and move your changelogs from 0.6.0 to 0.7.0? |
Of course @dahlia, rebase done ! |
@pBouillon We just released new version (0.6.0) few hours ago, so your change should be included in the next release (0.7.0). So could you please move changelogs you wrote from |
All set @dahlia, let me know if you would like any other modification |
/rebase |
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 90.62% 90.65% +0.03%
==========================================
Files 201 201
Lines 15116 15116
==========================================
+ Hits 13699 13704 +5
+ Misses 1131 1126 -5
Partials 286 286
|
@pBouillon Okay, everything seems alright! We are going to merge this patch immediately after the build passes. Thanks you for the contribution and following our picky requests. 🙏 |
Alright ! Thank you for your reactivity about this PR ! 😃 |
Rename variables in the
IRandom
interface according to #555