Fix GetState of block action to return proper state #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
previously approved these changes
Sep 6, 2019
earlbread
force-pushed
the
fix-block-action-get-state
branch
from
3e47519 to
9053d29
Compare
|
I rebased this on 0.5-maintenance branch. |
dahlia
reviewed
Sep 6, 2019
Co-Authored-By: Hong Minhee <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 0.5-maintenance #500 +/- ##
===================================================
- Coverage 88.04% 88.02% -0.03%
===================================================
Files 195 195
Lines 13770 13787 +17
===================================================
+ Hits 12124 12136 +12
- Misses 1334 1339 +5
Partials 312 312
|
dahlia
approved these changes
Sep 6, 2019
limebell
approved these changes
Sep 9, 2019
longfin
approved these changes
Sep 9, 2019
moreal
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug where
GetStatehadn't return proper state when the block action is evaluated.