-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Swarm<T>.BroadcastTxAsync() an exception from IStore on some race conditions #476
Fix Swarm<T>.BroadcastTxAsync() an exception from IStore on some race conditions #476
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.5-maintenance #476 +/- ##
===================================================
- Coverage 87.98% 87.95% -0.04%
===================================================
Files 195 195
Lines 13728 13770 +42
===================================================
+ Hits 12079 12111 +32
- Misses 1337 1346 +9
- Partials 312 313 +1
|
It's a little weird because this scenario didn't seem a race condition. ( FYI I've seen |
4950935
to
3c59bc6
Compare
0cd8241
to
7d6b1b4
Compare
470bfed
to
379b8bb
Compare
379b8bb
to
90043bd
Compare
The reason Linux/Mono builds failed was not due to this patch, but |
I believe this fixes #352, but I haven't found any concise way to reproduce this in unit tests…