Fix #465 #474
Merged
Fix #465 #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.5-maintenance #474 +/- ##
===================================================
- Coverage 87.96% 87.95% -0.02%
===================================================
Files 195 195
Lines 13698 13728 +30
===================================================
+ Hits 12050 12074 +24
- Misses 1336 1342 +6
Partials 312 312
|
limebell
approved these changes
Aug 28, 2019
longfin
approved these changes
Aug 28, 2019
earlbread
approved these changes
Aug 28, 2019
limebell
added a commit
to limebell/libplanet
that referenced
this pull request
Aug 30, 2019
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
Validate AP in ChargeActionpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #465 (comment) and the changelog.
I'm going to fix
Swarm<T>.SyncRecentStatesFromTrustedPeersAsync()method to find the proper branchpoint before sendingGetRecentStatesmessage in the master branch.