Remove unnecessary addressesToStrip parameter from IStore.ForkStateReferences() #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of planetarium#466
longfin
approved these changes
Aug 27, 2019
moreal
approved these changes
Aug 27, 2019
earlbread
approved these changes
Aug 27, 2019
limebell
approved these changes
Aug 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 87.97% 88.12% +0.14%
==========================================
Files 195 195
Lines 13729 13721 -8
==========================================
+ Hits 12078 12091 +13
+ Misses 1338 1318 -20
+ Partials 313 312 -1
|
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
Proof of concept: See candidate chains' generation number first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a port of the patch #466, and removes unnecessary
addressesToStripparameter fromIStore.ForkStateReferences()method.