Remove FileStore #446
Merged
Remove FileStore #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/remove-filestore
branch
from
871d7ad to
ee8278f
Compare
longfin
force-pushed
the
feature/remove-filestore
branch
from
ee8278f to
5036107
Compare
earlbread
approved these changes
Aug 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 88.14% 87.87% -0.28%
==========================================
Files 198 195 -3
Lines 14505 13669 -836
==========================================
- Hits 12785 12011 -774
+ Misses 1405 1346 -59
+ Partials 315 312 -3
|
dahlia
approved these changes
Aug 19, 2019
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
Merge main into rc-v100048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
FileStoreimplementation because it is difficult to maintain continuously.