Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More efficient way to store state references #398

Merged
merged 1 commit into from
Aug 6, 2019
Merged

More efficient way to store state references #398

merged 1 commit into from
Aug 6, 2019

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Aug 5, 2019

This fixes #395.

@dahlia dahlia added the bug Something isn't working label Aug 5, 2019
@dahlia dahlia added this to the 0.5.0 milestone Aug 5, 2019
@dahlia dahlia requested review from longfin, earlbread and moreal August 5, 2019 14:24
@dahlia dahlia self-assigned this Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019 •
edited
Loading

Codecov Report

Merging #398 into 9c-fft will increase coverage by 8%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           9c-fft     #398      +/-   ##
==========================================
+ Coverage   80.17%   88.17%      +8%     
==========================================
  Files          61      193     +132     
  Lines        1513    13736   +12223     
==========================================
+ Hits         1213    12112   +10899     
- Misses        271     1335    +1064     
- Partials       29      289     +260
Impacted Files Coverage Δ
Libplanet/Store/LiteDBStore.cs 90.88% <100%> (ø)
Libplanet.Tests/Store/LiteDBStoreTest.cs 96.42% <100%> (ø)
Libplanet/Net/Messages/BlockHashes.cs 100% <0%> (ø)
Libplanet/Net/NoSwarmContextException.cs 0% <0%> (ø)
Libplanet.Tests/Action/ActionEvaluationTest.cs 96.55% <0%> (ø)
Libplanet.Tests/Store/StoreTest.cs 98.83% <0%> (ø)
Libplanet.Tests/Store/FileStoreTest.cs 100% <0%> (ø)
Libplanet/Blocks/Block.cs 86.38% <0%> (ø)
Libplanet/Net/PeerSetDelta.cs 85.36% <0%> (ø)
...planet/Blockchain/Policies/BlockPolicyExtension.cs 100% <0%> (ø)
... and 124 more

earlbread
earlbread reviewed Aug 6, 2019
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
Libplanet.Tests/Store/LiteDBStoreTest.cs Show resolved Hide resolved
Libplanet/Store/LiteDBStore.cs Show resolved Hide resolved
Libplanet/Store/LiteDBStore.cs Outdated Show resolved Hide resolved
@dahlia dahlia force-pushed the litedb-state-refs branch from 1baadf8 to 338cf86 Compare August 6, 2019 05:55
@dahlia dahlia force-pushed the litedb-state-refs branch from 338cf86 to 8df25b3 Compare August 6, 2019 05:55
@dahlia dahlia requested a review from earlbread August 6, 2019 05:56
@dahlia dahlia merged commit 5183aba into planetarium:9c-fft Aug 6, 2019
@earlbread earlbread mentioned this pull request Sep 2, 2019
Closed
limebell pushed a commit to limebell/libplanet that referenced this pull request Jul 7, 2021
@ipdae
Merge pull request planetarium#398 from planetarium/improve/tradable-…
91af105 
…material

Fix Material sell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longfin longfin longfin approved these changes

@earlbread earlbread earlbread approved these changes

@moreal moreal moreal approved these changes

Assignees

@dahlia dahlia

Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dahlia @longfin @earlbread @moreal