Make transaction to pending that have the future nonce #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
approved these changes
Jul 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 88.01% 88.04% +0.02%
==========================================
Files 192 192
Lines 13454 13482 +28
==========================================
+ Hits 11842 11870 +28
+ Misses 1343 1341 -2
- Partials 269 271 +2
|
earlbread
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #362 and introduces another solution that makes transactions having the future nonce to pending and ignores them.