Remove id from BlockChain<T> constructor
#332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
reviewed
Jul 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 87.56% 87.66% +0.09%
==========================================
Files 189 189
Lines 12749 12777 +28
==========================================
+ Hits 11164 11201 +37
+ Misses 1335 1325 -10
- Partials 250 251 +1
|
longfin
force-pushed
the
feature/remove-chain-id-from-blockchain-constructor
branch
5 times, most recently
from
4f56064 to
f22eb73
Compare
longfin
force-pushed
the
feature/remove-chain-id-from-blockchain-constructor
branch
from
f22eb73 to
1c71797
Compare
earlbread
previously approved these changes
Jul 5, 2019
longfin
force-pushed
the
feature/remove-chain-id-from-blockchain-constructor
branch
from
1c71797 to
94dea55
Compare
|
I've renamed |
earlbread
approved these changes
Jul 5, 2019
dahlia
approved these changes
Jul 5, 2019
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
Bump libplanet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #279 by removing the
idparameter fromBlockChain<T>constructor. it also madeBlockChain<T>.Idto be automatically determined by chain height.