Force dotnet if running on mono #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
bugfix/asyncio-force-dotnet
branch
2 times, most recently
from
d8dc061 to
10476bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 87.27% 87.08% -0.19%
==========================================
Files 180 180
Lines 11394 11386 -8
==========================================
- Hits 9944 9916 -28
- Misses 1207 1227 +20
Partials 243 243
|
longfin
force-pushed
the
bugfix/asyncio-force-dotnet
branch
7 times, most recently
from
5d37578 to
09c0abc
Compare
earlbread
reviewed
May 21, 2019
| new HashSet<Peer> { null, b.AsPeer, c.AsPeer }, | ||
| peers.ToHashSet()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Swarm is not going to be used as an ICollection anymore?
There was a problem hiding this comment.
I will try to do so. would it be better to handle this issue?
There was a problem hiding this comment.
No, I think it would be better to handle this in another PR.
earlbread
previously approved these changes
May 21, 2019
longfin
force-pushed
the
bugfix/asyncio-force-dotnet
branch
from
09c0abc to
3b44a66
Compare
longfin
force-pushed
the
bugfix/asyncio-force-dotnet
branch
from
3b44a66 to
e5938ce
Compare
|
It still appears intermittently failing, but seems to be more stabilized than before. PTAL @earlbread @dahlia |
dahlia
approved these changes
May 22, 2019
earlbread
approved these changes
May 22, 2019
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this pull request
Jan 31, 2023
…netarium#247) * INTERNAL: update configmap-versions.yaml * INTERNAL: update kustomization.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncIO.ForceDotNet.Force()to enforce using sockets in .NET, not Windows native.Swarm.Add()usages.ArgumentOutOfRangeExceptionthat occurred when requesting a hash whenBlockChain <T>was empty.