Tune lock in BlockChain<T> #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/tune-blockchain-lock
branch
from
367f092 to
42a969a
Compare
longfin
requested review from
dahlia and
earlbread
and removed request for
dahlia
earlbread
previously approved these changes
Apr 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
- Coverage 84.1% 83.85% -0.25%
==========================================
Files 75 75
Lines 3492 3488 -4
==========================================
- Hits 2937 2925 -12
- Misses 555 563 +8
|
longfin
force-pushed
the
feature/tune-blockchain-lock
branch
from
42a969a to
bee27da
Compare
dahlia
reviewed
Apr 26, 2019
dahlia
reviewed
Apr 26, 2019
longfin
force-pushed
the
feature/tune-blockchain-lock
branch
from
bee27da to
fbd0f6e
Compare
earlbread
reviewed
Apr 28, 2019
earlbread
previously approved these changes
Apr 28, 2019
dahlia
previously approved these changes
Apr 29, 2019
longfin
force-pushed
the
feature/tune-blockchain-lock
branch
from
eb2e74b to
7f9ff17
Compare
dahlia
reviewed
Apr 29, 2019
longfin
force-pushed
the
feature/tune-blockchain-lock
branch
from
7f9ff17 to
ea5b69c
Compare
dahlia
approved these changes
Apr 29, 2019
earlbread
approved these changes
Apr 29, 2019
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this pull request
Jan 31, 2023
update nodegroups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the locks on
BlockChain<T>.BlockChain<T>.StageTransactions()BlockChain<T>.GetState()locks to reduce locking period.