Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce block broadcaster #1351

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

longfin
Copy link
Member

@longfin longfin commented Jun 23, 2021

This PR adds the worker task to broadcast chain tip repeatedly.

@longfin longfin added the network Related to networking (Libplanet.Net) label Jun 23, 2021
@longfin longfin self-assigned this Jun 23, 2021
@longfin longfin force-pushed the feature/block-broadcaster branch from 355c606 to a68b983 Compare June 23, 2021 12:34
@longfin longfin marked this pull request as ready for review June 23, 2021 12:34
@longfin longfin force-pushed the feature/block-broadcaster branch from a68b983 to 2108edf Compare June 23, 2021 12:47
@longfin longfin force-pushed the feature/block-broadcaster branch from 2108edf to 98fb28a Compare June 24, 2021 01:40
@limebell
Copy link
Member

Tests seems to fail very often. Can you please check?

@longfin longfin force-pushed the feature/block-broadcaster branch 2 times, most recently from 38e9457 to 77aba9b Compare June 24, 2021 06:56
limebell
limebell previously approved these changes Jun 24, 2021
@longfin
Copy link
Member Author

longfin commented Jun 28, 2021

/rebase

@longfin
Copy link
Member Author

longfin commented Jun 29, 2021

/rebase

@libplanet libplanet force-pushed the feature/block-broadcaster branch from 319993f to 8795c84 Compare June 29, 2021 05:05
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1351 (7aa66e5) into main (17c21fb) will increase coverage by 0.06%.
The diff coverage is 68.00%.

@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
+ Coverage   76.94%   77.01%   +0.06%     
==========================================
  Files         253      253              
  Lines       16991    17016      +25     
==========================================
+ Hits        13074    13105      +31     
+ Misses       3388     3379       -9     
- Partials      529      532       +3     
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 83.98% <68.00%> (+1.77%) ⬆️
Libplanet/Net/BlockCompletion.cs 94.20% <0.00%> (-0.87%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 67.04% <0.00%> (-0.75%) ⬇️
Libplanet.RocksDBStore/RocksDBStore.cs 77.81% <0.00%> (-0.26%) ⬇️

@longfin longfin merged commit 301f616 into planetarium:main Jun 29, 2021
longfin added a commit that referenced this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network Related to networking (Libplanet.Net)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants