Miner is no longer nullable #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greymistcube
added
invalid
Codecov Report
@@ Coverage Diff @@
## main #1341 +/- ##
==========================================
+ Coverage 77.08% 77.14% +0.06%
==========================================
Files 256 256
Lines 17262 17257 -5
==========================================
+ Hits 13306 13313 +7
+ Misses 3390 3378 -12
Partials 566 566
|
limebell
previously approved these changes
Jun 14, 2021
|
What happens if deserializing pre-existing blocks with null miner? |
|
Hmm... libplanet/Libplanet/Blocks/BlockHeader.cs Line 119 in 9e0e63d If a key/value pair is present, but the value is empty, then again, deserialization would fail on: libplanet/Libplanet/Blocks/Block.cs Line 168 in 9e0e63d I'm assuming creation of malformed |
longfin
previously approved these changes
Jun 21, 2021
greymistcube
force-pushed
the
refactor/non-nullable-miner
branch
2 times, most recently
from
43fe1d5 to
2250357
Compare
|
/rebase |
libplanet
force-pushed
the
refactor/non-nullable-miner
branch
from
2250357 to
6983399
Compare
greymistcube
force-pushed
the
refactor/non-nullable-miner
branch
4 times, most recently
from
bd695b7 to
2b68661
Compare
greymistcube
force-pushed
the
refactor/non-nullable-miner
branch
from
2b68661 to
00ddc70
Compare
limebell
previously approved these changes
Jul 8, 2021
limebell
reviewed
Jul 8, 2021
greymistcube
force-pushed
the
refactor/non-nullable-miner
branch
from
526163d to
51f4e43
Compare
greymistcube
force-pushed
the
refactor/non-nullable-miner
branch
from
51f4e43 to
1cb52bf
Compare
|
/rebase |
libplanet
force-pushed
the
refactor/non-nullable-miner
branch
from
1cb52bf to
3b22396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless we want to support blockchain architecture where blocks without miners are allowed as a feature, there doesn't seem to be a real necessity for having
nullminerAddressforBlock<T>. On a side note, having a dummyAddressor a specialAddressreserved for unforeseen future purposes might come in handy for the convenience of development. Just spitballing, but something like/dev/nullAddress"eating up"Transaction<T>s and/orIActions might be useful. Perhaps we should reserve0and/or1?