Patch/transaction ordering update

[greymistcube]

Closes #1322
Closes #1323

Ordering Transaction<T>s for evaluation has been separated from Block<T>() constructor as Block<T>.OrderTxsForEvaluation() static method. Additionally, in preparation for #1314, a new ordering algorithm has been introduced. New algorithm will kick in once ProtocalVersion gets increased to at least 2. Finally, pre-existing algorithm has been optimized for time and memory.

Here are some scripted benchmark results:

Number of Signers: 10
Number of Txs per Signer: 10
Running 1000 trials...

Old shuffling time: 2452 ticks
NewV0 shuffling time: 776 ticks
NewV2 shuffling time: 379 ticks

Number of Signers: 100
Number of Txs per Signer: 100
Running 1000 trials...

Old shuffling time: 190516 ticks
NewV0 shuffling time: 103822 ticks
NewV2 shuffling time: 26516 ticks

[codecov]

Codecov Report

Merging #1326 (c5a7652) into main (0033ed7) will decrease coverage by 9.10%.
The diff coverage is 53.94%.

❗ Current head c5a7652 differs from pull request most recent head 6e4d373. Consider uploading reports for the commit 6e4d373 to get more accurate results

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   86.03%   76.93%   -9.11%     
==========================================
  Files         361      253     -108     
  Lines       32457    17082   -15375     
==========================================
- Hits        27925    13142   -14783     
- Misses       2747     3410     +663     
+ Partials     1785      530    -1255     

Impacted Files	Coverage Δ
...bplanet.Explorer/Controllers/ExplorerController.cs	0.00% <0.00%> (ø)
...rer/Controllers/GenericControllerNameConvention.cs	0.00% <0.00%> (ø)
Libplanet.Explorer/Controllers/GraphQLBody.cs	0.00% <0.00%> (ø)
Libplanet.Explorer/ExplorerStartup.cs	0.00% <0.00%> (ø)
Libplanet.Explorer/GraphTypes/NodeStateType.cs	0.00% <0.00%> (ø)
...ibplanet.Explorer/Interfaces/IBlockChainContext.cs	0.00% <0.00%> (ø)
Libplanet.Explorer/Queries/BlockQuery.cs	0.00% <0.00%> (ø)
Libplanet.Explorer/Queries/ExplorerQuery.cs	0.00% <0.00%> (ø)
Libplanet.Explorer/Queries/TransactionQuery.cs	0.00% <0.00%> (ø)
Libplanet.Explorer/Store/AddressRefDoc.cs	0.00% <0.00%> (ø)
... and 247 more

[limebell]

Can you please add a test case for this change? It would be great the added test fails at previous protocol, and pass at modified protocol.

And it would be great to have changelog describing this patch (in behavioral changes section).

[longfin]

/rebase

[greymistcube]

@limebell

Can you please add a test case for this change?

See 89a0add. Hard coded spec is added to ensure that there is no behavioral change between the new optimized V0 implementation and the old implementation.

It would be great the added test fails at previous protocol, and pass at modified protocol.

Previous protocol doesn't "fail" per se, but does not work as intended. This is described in more detail in #1323. Statistical analysis may be done, but I don't see much point in doing so, and I'm not sure such test should be a part of unit testing. 😶

And it would be great to have changelog describing this patch (in behavioral changes section).

See 025a55f.

[limebell]

/rebase

[longfin]

@greymistcube it has a conflicting file...

[greymistcube]

@longfin Resolved.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[limebell]

not stale

[greymistcube]

/rebase