feat(cli): introduce planet key derive
#1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
dahlia,
limebell,
longfin and
riemannulus
Codecov Report
@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
- Coverage 84.04% 84.02% -0.03%
==========================================
Files 398 398
Lines 34110 34110
==========================================
- Hits 28667 28660 -7
- Misses 3617 3625 +8
+ Partials 1826 1825 -1
|
|
Could you review this pull request, @libplanet ? |
riemannulus
previously approved these changes
Apr 27, 2021
dahlia
reviewed
Apr 27, 2021
moreal
force-pushed
the
feature/cli/provide-conversion-command
branch
2 times, most recently
from
9b71469 to
7517a10
Compare
dahlia
reviewed
Apr 27, 2021
longfin
changed the title
planet key convertplanet key derive
dahlia
reviewed
Apr 28, 2021
moreal
force-pushed
the
feature/cli/provide-conversion-command
branch
from
cdc27e8 to
e573ce6
Compare
dahlia
previously approved these changes
Apr 28, 2021
Co-Authored-By: Hong.Minhee <[email protected]>
Co-Authored-By: Hong.Minhee <[email protected]>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
moreal
force-pushed
the
feature/cli/provide-conversion-command
branch
from
e573ce6 to
ac21b6d
Compare
|
Could you review this pull request? @libplanet 🙏🏻 |
dahlia
approved these changes
Apr 29, 2021
limebell
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introdcues
planet key convert private-keysubcommand to provide conversion private key → public key and private key → address.