Fix BlockChain<T>.Append() to disallow block with too many txs #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the commit 1d35777, we added IBlockPolicy<T>.MaxTransactionsPerBlock property, but it had only functioned as a default value for BlockChain<T>.MineBlock() method's maxTransactions option. This had misled and been unintended, because BlockChain<T>.Append() still had accept blocks violating its policy (Block<T> having more Transactions than the number a policy allows still can be made with Block<T>.Mine() method). Although this adds BlockExceedingTransactionsException class, since it would be released as a patch release, it's not public yet. We should make it public when it's ported to the upstream main (next major/minor release).
longfin
approved these changes
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## 0.10-maintenance #1104 +/- ##
====================================================
- Coverage 88.33% 88.27% -0.06%
====================================================
Files 345 347 +2
Lines 31917 31986 +69
====================================================
+ Hits 28194 28236 +42
- Misses 2041 2062 +21
- Partials 1682 1688 +6
|
moreal
approved these changes
Nov 25, 2020
This was referenced Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the commit 1d35777, we added
IBlockPolicy<T>.MaxTransactionsPerBlockproperty, but it had only functioned as a default value forBlockChain<T>.MineBlock()method'smaxTransactionsoption. This had misled and been unintended, becauseBlockChain<T>.Append()still had accept blocks violating its policy (Block<T>having moreTransactionsthan the number a policy allows still can be made withBlock<T>.Mine()method).Although this adds
BlockExceedingTransactionsExceptionclass, since it would be released as a patch release, it's notpublicyet. We should make itpublicwhen it's ported to the upstream main (next major/minor release).